| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 Sep 2006 11:35:16 +1000 From: Stephen Rothwell <sfr@...b.auug.org.au> To: David Howells <dhowells@...hat.com> Cc: torvalds@...l.org, akpm@...l.org, linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org Subject: Re: [PATCH 5/7] Alter get_order() so that it can make use of ilog2() on a constant [try #3] Hi David, On Thu, 14 Sep 2006 12:52:04 +0100 David Howells <dhowells@...hat.com> wrote: > > Stephen Rothwell <sfr@...b.auug.org.au> wrote: > > > After this patch, you don't need to include <linux/compiler.h> any more > > (and, in fact, the file ends up essentially empty). > > True. I could possibly delete the whole file, depending on who else has > designs on it. I think the patch consolidating PAGE_SIZE may want it. > > Is there a good reason to move this function out of asm-generic/page.h? > > So that all the general log2-based functions are grouped together was what I > was thinking (at least their primary interfaces). Except the get_order() interface is purely related to pages (the fact that you have reimplemented it using the log2-based functions is just an implementation detail. -- Cheers, Stephen Rothwell sfr@...b.auug.org.au http://www.canb.auug.org.au/~sfr/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists