lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 18 Sep 2006 19:09:52 -0700
From:	David Brownell <david-b@...bell.net>
To:	linux-usb-devel@...ts.sourceforge.net
Cc:	Jiri Kosina <jikos@...os.cz>, Andrew Morton <akpm@...l.org>,
	dbrownell@...rs.sourceforge.net, weissg@...nna.at,
	linux-kernel@...r.kernel.org
Subject: Re: [linux-usb-devel] [PATCH] USB: consolidate error values from EHCI, UHCI and OHCI _suspend()

On Monday 18 September 2006 6:44 pm, Jiri Kosina wrote:
> Hi,
> 
> EHCI, UHCI and OHCI USB host drivers are not consistent when returining 
> error values from their _suspend() functions, in case that the device is 
> not in suspended state. This could confuse users, so let all three of them 
> return -EBUSY.

Shouldn't you also update uhci_suspend()?  Currently it
just ignores hcd->state ...


> Patch against 2.6.18-rc6-mm2.
> 
> Signed-off-by: Jiri Kosina <jikos@...os.cz>
> 
> --- linux-2.6.18-rc6-mm2.orig/drivers/usb/host/ehci-pci.c	2006-09-14 16:20:48.000000000 +0200
> +++ linux-2.6.18-rc6-mm2/drivers/usb/host/ehci-pci.c	2006-09-19 03:20:22.000000000 +0200
> @@ -232,7 +232,7 @@ static int ehci_pci_suspend(struct usb_h
>  	 */
>  	spin_lock_irqsave (&ehci->lock, flags);
>  	if (hcd->state != HC_STATE_SUSPENDED) {
> -		rc = -EINVAL;
> +		rc = -EBUSY;
>  		goto bail;
>  	}
>  	writel (0, &ehci->regs->intr_enable);
> --- linux-2.6.18-rc6-mm2.orig/drivers/usb/host/ohci-pci.c	2006-09-14 16:20:48.000000000 +0200
> +++ linux-2.6.18-rc6-mm2/drivers/usb/host/ohci-pci.c	2006-09-19 03:36:35.000000000 +0200
> @@ -130,7 +130,7 @@ static int ohci_pci_suspend (struct usb_
>  	 */
>  	spin_lock_irqsave (&ohci->lock, flags);
>  	if (hcd->state != HC_STATE_SUSPENDED) {
> -		rc = -EINVAL;
> +		rc = -EBUSY;
>  		goto bail;
>  	}
>  	ohci_writel(ohci, OHCI_INTR_MIE, &ohci->regs->intrdisable);
> 
> -- 
> Jiri Kosina
> 
> -------------------------------------------------------------------------
> Take Surveys. Earn Cash. Influence the Future of IT
> Join SourceForge.net's Techsay panel and you'll get the chance to share your
> opinions on IT & business topics through brief surveys -- and earn cash
> http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
> _______________________________________________
> linux-usb-devel@...ts.sourceforge.net
> To unsubscribe, use the last form field at:
> https://lists.sourceforge.net/lists/listinfo/linux-usb-devel
> 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists