linux-kernel - Re: [PATCH 1/2] [MMC] Driver for TI FlashMedia card reader

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Sep 2006 23:20:16 -0700
From:	Andrew Morton <akpm@...l.org>
To:	Alex Dubov <oakad@...oo.com>
Cc:	linux-kernel@...r.kernel.org, drzeus-list@...eus.cx,
	rmk+lkml@....linux.org.uk
Subject: Re: [PATCH 1/2] [MMC] Driver for TI FlashMedia card reader - source

On Tue, 19 Sep 2006 23:02:11 -0700 (PDT)
Alex Dubov <oakad@...oo.com> wrote:

> Driver for TI Flash Media card reader. At present, only MMC/SD
> cards are supported.

Could I ask where the information which permitted this (nice-looking) driver to
be written came from?

Trivia:

There's some whitespace damage in there.  Please search the diff for "^ "
and fix it up.

We indent the body of switch statements one tab stop less than this driver
does.

The driver has lots of really big inlined functions.  It's best to uninline
these.  If the function has a single callsite, gcc will inline it anyway. 
If the function has multiple callsites (now, or in the future), inlining it
is undesirable.

The driver has a lot of things like

	static inline void* tifm_get_drvdata(struct tifm_dev *dev)

whereas we prefer

	static inline void *tifm_get_drvdata(struct tifm_dev *dev)

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/