linux-kernel - [RETRY] [PATCH] load_module: no BUG if module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 22 Sep 2006 12:48:48 -0700
From:	"Ed Swierk" <eswierk@...stra.com>
To:	linux-kernel@...r.kernel.org
Cc:	rusty@...tcorp.com.au
Subject: [RETRY] [PATCH] load_module: no BUG if module_subsys uninitialized

[I discovered after sending my previous message that Gmail helpfully
line-wrapped and de-tabified my patch. I'm resending it as an
attachment; apologies for the error.]

Invoking load_module() before param_sysfs_init() is called crashes in
mod_sysfs_setup(), since the kset in module_subsys is not initialized
yet.

Another patch for the same symptom
(module_subsys-initialize-earlier.patch) moves param_sysfs_init() to
the subsys initcalls, but this is still not early enough in the boot
process in some cases. In particular, topology_init() causes
/sbin/hotplug to run, which requests net-pf-1 (the UNIX socket
protocol) which can be compiled as a module. Moving param_sysfs_init()
to the postcore initcalls fixes this particular race, but there might
well be other cases where a usermodehelper causes a module to load
earlier still.

The patch below makes load_module() return an error rather than
crashing the kernel if invoked before module_subsys is initialized.

View attachment "module_subsys-uninit-return-err.patch" of type "text/x-patch" (465 bytes)