lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Wed, 27 Sep 2006 15:58:03 -0700
From:	James Ketrenos <jketreno@...ux.intel.com>
To:	Andrew Morton <akpm@...l.org>
CC:	Miles Lane <miles.lane@...il.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Jouni Malinen <jkmaline@...hut.fi>
Subject: Re: 2.6.18-mm1 -- ieee80211: Info elem: parse failed: info_element->len
 + 2 > left : info_element->len+2=28 left=9, id=221.

Andrew Morton wrote:
> On Wed, 27 Sep 2006 13:47:18 -0700
> James Ketrenos <jketreno@...ux.intel.com> wrote:
> 
>> +static int snprint_line(char *buf, size_t count,
>> +			const u8 * data, u32 len, u32 ofs)
>> +{
>> +	int out, i, j, l;
>> +	char c;
>> +
>> +	out = snprintf(buf, count, "%08X", ofs);
>> +
>> +	for (l = 0, i = 0; i < 2; i++) {
>> +		out += snprintf(buf + out, count - out, " ");
>> +		for (j = 0; j < 8 && l < len; j++, l++)
>> +			out += snprintf(buf + out, count - out, "%02X ",
>> +					data[(i * 8 + j)]);
>> +		for (; j < 8; j++)
>> +			out += snprintf(buf + out, count - out, "   ");
>> +	}
>> +
>> +	out += snprintf(buf + out, count - out, " ");
>> +	for (l = 0, i = 0; i < 2; i++) {
>> +		out += snprintf(buf + out, count - out, " ");
>> +		for (j = 0; j < 8 && l < len; j++, l++) {
>> +			c = data[(i * 8 + j)];
>> +			if (!isascii(c) || !isprint(c))
>> +				c = '.';
>> +
>> +			out += snprintf(buf + out, count - out, "%c", c);
>> +		}
>> +
>> +		for (; j < 8; j++)
>> +			out += snprintf(buf + out, count - out, " ");
>> +	}
>> +
>> +	return out;
>> +}
> 
> I've occasionally felt that the kernel should have a generic
> print-a-hunk-of-memory function (slab.c has two open-coded
> implementations already).
> 
> What does the output of this one look like?

The formatting was done to look pretty similar to generic hex editors/dumpers:

00000000 80 00 00 00 FF FF FF FF  FF FF 00 14 6C 9E C1 1E   ........ ....l...
00000010 00 14 6C 9E C1 1E 00 AF  86 07 D7 DC 11 00 00 00   ..l..... ........
00000020 64 00 01 04 00 07 4E 45  54 47 45 41 52 01 08 82   d.....NE TGEAR...
00000030 84 8B 96 24 30 48 6C 03  01 0B 05 04 00 01 00 00   ...$0Hl. ........
00000040 2A 01 02 2F 01 02 32 04  0C 12 18 60 DD 06 00 10   *../..2. ...`....
00000050 18 02 00 00

The above was generated via printk_buf() with an 84 byte buffer passed in.

James
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ