lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Mon, 02 Oct 2006 12:50:22 +0100
From:	Paulo Marques <pmarques@...popie.com>
To:	Thomas Gleixner <tglx@...utronix.de>
CC:	Andrew Morton <akpm@...l.org>, LKML <linux-kernel@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>, Jim Gettys <jg@...top.org>,
	John Stultz <johnstul@...ibm.com>,
	David Woodhouse <dwmw2@...radead.org>,
	Arjan van de Ven <arjan@...radead.org>,
	Dave Jones <davej@...hat.com>
Subject: Re: [patch 16/21] high-res timers: core

Thomas Gleixner wrote:
> [...]
> Index: linux-2.6.18-mm2/kernel/hrtimer.c
> ===================================================================
> --- linux-2.6.18-mm2.orig/kernel/hrtimer.c	2006-10-02 00:55:53.000000000 +0200
> +++ linux-2.6.18-mm2/kernel/hrtimer.c	2006-10-02 00:55:54.000000000 +0200
> @@ -38,7 +38,11 @@
>  #include <linux/hrtimer.h>
>  #include <linux/notifier.h>
>  #include <linux/syscalls.h>
> +#include <linux/kallsyms.h>

I'm not really knowledgeable in timer code to review these patches, but 
I always keep an eye out for kallsyms uses.

It seems that this include is unused. Maybe it was some debug stuff that 
got moved (or removed) later?

The patch to kernel/timer.c seems to have the same unused include, too.

-- 
Paulo Marques - www.grupopie.com

"The face of a child can say it all, especially the
mouth part of the face."
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ