linux-kernel - [PATCH] usb hubc build fix.patch prefix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 01 Oct 2006 19:37:20 -0700
From:	Paul Jackson <pj@....com>
To:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org
Cc:	Alan Stern <stern@...land.harvard.edu>, Paul Jackson <pj@....com>,
	Greg KH <greg@...ah.com>
Subject: [PATCH] usb hubc build fix.patch prefix

From: Paul Jackson <pj@....com>

The patch series 2.6.18-mm2-broken-out does not apply to 2.6.18,
for me anyway.

The 'quilt push' of this series fails with:

    Applying patch usb-hubc-build-fix.patch
    patching file drivers/usb/core/hub.c
    Hunk #1 FAILED at 1831.
    Hunk #2 succeeded at 1904 (offset -2 lines).
    Hunk #3 FAILED at 1946.
    2 out of 3 hunks FAILED -- rejects in file drivers/usb/core/hub.c
    Patch usb-hubc-build-fix.patch does not apply (enforce with -f)

If I apply the following patch *just before* the failing
usb-hubc-build-fix.patch, everything applies cleanly from there on
down the patch set.

I don't know what's right here.  I'm just blindly pushing code.

But it seems obvious to me that the 2.6.18-mm2 broken-out patch set
is borked:

  The first patch in the series: origin.patch, definitely places these
  two hub_* defines just before the usb_resume_root_hub() routine.
  
  But then the patch usb-hubc-build-fix.patch clearly expects to find
  those two hub_* defines just before the hub_suspend() routine.

Signed-off-by: Paul Jackson <pj@....com>

---
 drivers/usb/core/hub.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

--- 2.6.18-mm2.orig/drivers/usb/core/hub.c	2006-10-01 17:52:53.000000000 -0700
+++ 2.6.18-mm2/drivers/usb/core/hub.c	2006-10-01 18:26:17.000000000 -0700
@@ -1862,6 +1862,8 @@ static inline int remote_wakeup(struct u
 	return 0;
 }
 
+#define hub_suspend NULL
+#define hub_resume NULL
 #endif
 
 static int hub_suspend(struct usb_interface *intf, pm_message_t msg)
@@ -1946,8 +1948,6 @@ static inline int remote_wakeup(struct u
 	return 0;
 }
 
-#define hub_suspend NULL
-#define hub_resume NULL
 #endif
 
 void usb_resume_root_hub(struct usb_device *hdev)

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@....com> 1.925.600.0401
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/