linux-kernel - Re: 2.6.18-rc6-mm2: fix for error compiling ppc/mm/init.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 03 Oct 2006 22:12:32 +1000
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Mel Gorman <mel@....ul.ie>
Cc:	Judith Lebzelter <judith@...l.org>, linux-kernel@...r.kernel.org,
	akpm@...l.org, Paul Mackerras <paulus@...ba.org>
Subject: Re: 2.6.18-rc6-mm2: fix for error compiling ppc/mm/init.c


> Once we have a patch using symbolic names working on ppc, I'll make a 
> patch that uses symbolic names on the other architectures and post it.

Ok, good :) I don't like magic numbers

> I don't know if it has been fixed either.

Yeah... I'm not in a mood to audit all of that for 2.6.19, so I'd rather
keep it the way it is for now.

> Once we get ppc sorted, I'll make a patch that uses explicit array 
> initialisation and symbolic index names on the other arches.

Ok. Any reason why my current patch wouldn't be good then ? If it's ok
for you, I'll put it in paulus queue for merging.

> I believe it was to stop having more empty zones than was really 
> necessary. It was a saving on NUMA. I might be wrong, I'll need to check 
> the archives again.

Well, as long as we use named indices in the array and make sure it's
properly initialized to 0, that should be ok.

> You're right. The generic code does handle this case because at one point, 
> I remembered clearly that not all zones would be in use :/

Good then :)

Cheers,
Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/