linux-kernel - Re: [linux-pm] [RFC] OMAP1 PM Core, PM Core Implementation 2/2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 4 Oct 2006 23:25:45 +0200
From:	Pavel Machek <pavel@....cz>
To:	"Scott E. Preece" <preece@...orola.com>
Cc:	shd@...alwe.fi, linux-pm@...ts.osdl.org,
	linux-kernel@...r.kernel.org, ext-Tuukka.Tikkanen@...ia.com
Subject: Re: [linux-pm] [RFC] OMAP1 PM Core, PM Core  Implementation 2/2

Hi!

> | > > > +static long 
> | > > > +get_vtg(const char *vdomain)
> | > > > +{
> | > > > +	long ret = 0;
> | > > 
> | > > Unnecessary initialisation.
> | > 
> | > No, sorry.
> | 
> | In get_vtg(), if VOLTAGE_FRAMEWORK is defined then
> | 
> | 	ret = vtg_get_voltage(v);
> | 
> | is the first user. If VOLTAGE_FRAMEWORK is not defined, the first user is:
> | 
> | 	ret = vtg_get_voltage(&vhandle);
> | 
> | Then "return ret;" follows. I cannot see a path where 
> | pre-initialisation of ret does anything useful. If someone removed the
> | #else part, the compiler would bark.
> ---
> 
> True, but a good compiler should remove the dead initialization...

True, but efficient code is only one of constraints. Code should be
easy to read, too.
								Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/