linux-kernel - Re: Problems with hard irq? (inconsistent lock state)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 5 Oct 2006 11:05:44 -0700
From:	Greg KH <gregkh@...e.de>
To:	Jarek Poplawski <jarkao2@...pl>,
	"Axel C. Voigt" <Axel.Voigt@...motec.com>,
	linux-kernel@...r.kernel.org, David Kubicek <dave@....cz>
Subject: Re: Problems with hard irq? (inconsistent lock state)

On Wed, Oct 04, 2006 at 08:45:43AM +0200, Jarek Poplawski wrote:
> On Tue, Oct 03, 2006 at 10:43:09PM -0700, Greg KH wrote:
> > On Wed, Oct 04, 2006 at 07:43:08AM +0200, Jarek Poplawski wrote:
> > > On 29-09-2006 13:45, Axel C. Voigt wrote:
> ...
> > > > Sep 29 13:29:53 mcs70 kernel: =================================
> > > > Sep 29 13:29:53 mcs70 kernel: [ INFO: inconsistent lock state ]
> > > > Sep 29 13:29:53 mcs70 kernel: ---------------------------------
> > > > Sep 29 13:29:53 mcs70 kernel: inconsistent {hardirq-on-W} -> {in-hardirq-W} usage.
> > > > Sep 29 13:29:53 mcs70 kernel: startDV24/3864 [HC1[1]:SC0[0]:HE0:SE1] takes:
> > > > Sep 29 13:29:53 mcs70 kernel: (&acm->read_lock){++..}, at: [<e08952d8>] acm_read_bulk+0x60/0xde [cdc_acm]
> > > > Sep 29 13:29:53 mcs70 kernel: {hardirq-on-W} state was registered at:
> ...
> > > It looks in drivers/usb/class/cdc-acm.c acm_rx_tasklet could be preempted
> > > with acm->read_lock by acm_read_bulk which uses the same lock from hardirq
> > > context.
> > > 
> > > So probably spin_lock_irqsave is needed.  
> > 
> > Yup.  Care to send a patch?
> 
> If it could help?

Great, care to resend this to me with a signed-off-by: line?

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/