linux-kernel - Re: [PATCH] make mach-generic/summit.c compile on UP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 05 Oct 2006 13:31:32 -0700
From:	keith mannthey <kmannth@...ibm.com>
To:	Jiri Kosina <jikos@...os.cz>
Cc:	lkml <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...l.org>
Subject: Re: [PATCH] make mach-generic/summit.c compile on UP

On Thu, 2006-10-05 at 19:16 +0200, Jiri Kosina wrote:
> Hi,
> 
> arch/i386/mach-generic/summit.c doesn't compile (neither in current 
> mainline git tree, nor in 2.6.18-mm3) when CONFIG_SMP is not set:
> 
> In file included from arch/i386/mach-generic/summit.c:17:
> include/asm/mach-summit/mach_apic.h: In function 'apicid_to_node':
> include/asm/mach-summit/mach_apic.h:91: error: 'apicid_2_node' undeclared (first use in this function)
> include/asm/mach-summit/mach_apic.h:91: error: (Each undeclared identifier is reported only once
> include/asm/mach-summit/mach_apic.h:91: error: for each function it appears in.)
> Is the patch below correct?

Well I guess it would fix the apicid_2_node build error but I can't
think of a single good reason to be in a config where you would need any
of the summit code in UP.  Perhaps a kconfig or makefile change in the
right spot would be better. 

Can you send along your config file so I can better understand?  I seem
to be able to build i386 UP just fine.  

Thanks, 
  Keith 

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/