linux-kernel - Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than passing to IRQ handlers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 06 Oct 2006 07:15:08 -0400
From:	Jeff Garzik <jeff@...zik.org>
To:	Alan Cox <alan@...rguk.ukuu.org.uk>
CC:	David Howells <dhowells@...hat.com>, Andrew Morton <akpm@...l.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>, torvalds@...l.org,
	linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
	Dmitry Torokhov <dtor@...l.ru>, Greg KH <greg@...ah.com>,
	David Brownell <david-b@...bell.net>,
	Alan Stern <stern@...land.harvard.edu>
Subject: Re: [PATCH 3/3] IRQ: Maintain regs pointer globally rather than	passing
 to IRQ handlers

Alan Cox wrote:
> Ar Iau, 2006-10-05 am 20:52 -0400, ysgrifennodd Jeff Garzik:
>> The overwhelming majority of irq handlers don't use the 'irq' argument 
>> either...  the driver-supplied pointer is what drivers use, exclusively, 
>> to differentiate between different instances.
>>
>> If we are going to break all the irq handlers, I'd suggest going ahead 
>> and removing that one too.
> 
> NAK to that, it will mess up a lot of older drivers which still use the
> irq field and also those who want it to print

Look at the pt_regs change -- the irq change is similar:

The information does not go away, it is merely available via another avenue.

	Jeff



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/