linux-kernel - [PATCH] spufs: fix support for read/write on cntl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 10 Oct 2006 10:27:29 +0200
From:	Arnd Bergmann <arnd.bergmann@...ibm.com>
To:	"Noguchi, Masato" <Masato.Noguchi@...sony.com>
Cc:	"Paul Mackerras" <paulus@...ba.org>, linuxppc-dev@...abs.org,
	cbe-oss-dev@...abs.org, linux-kernel@...r.kernel.org
Subject: [PATCH] spufs: fix  support for read/write on cntl

From: "Noguchi, Masato" <Masato.Noguchi@...sony.com>

This fixes a memory leak introduced by "spufs: add support
for read/write oncntl", which was missing a call to simple_attr_close.

Signed-off-by: Masato Noguchi <Masato.Noguchi@...sony.com>
Signed-off-by: Arnd Bergmann <arnd.bergmann@...ibm.com>

---

On Tuesday 10 October 2006 08:49, Noguchi, Masato wrote:
> Oops,
> I'm so sorry. I mistake to send wrong patch.

Ok, no worries. Paul, please use this patch instead.

Index: linux-2.6/arch/powerpc/platforms/cell/spufs/file.c
===================================================================
--- linux-2.6.orig/arch/powerpc/platforms/cell/spufs/file.c
+++ linux-2.6/arch/powerpc/platforms/cell/spufs/file.c
@@ -246,6 +246,7 @@ static int spufs_cntl_open(struct inode 
 
 static struct file_operations spufs_cntl_fops = {
 	.open = spufs_cntl_open,
+	.release = simple_attr_close,
 	.read = simple_attr_read,
 	.write = simple_attr_write,
 	.mmap = spufs_cntl_mmap,
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/