lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 10 Oct 2006 10:42:51 +1000 From: Nick Piggin <nickpiggin@...oo.com.au> To: Benjamin Herrenschmidt <benh@...nel.crashing.org> CC: Nick Piggin <npiggin@...e.de>, Hugh Dickins <hugh@...itas.com>, Linux Memory Management <linux-mm@...ck.org>, Andrew Morton <akpm@...l.org>, Jes Sorensen <jes@....com>, Linux Kernel <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu> Subject: Re: [patch 4/5] mm: add vm_insert_pfn helpler Benjamin Herrenschmidt wrote: >>+ vma->vm_flags |= VM_PFNMAP; > > > I wouldn't do that here. I would keep that to the caller (and set it > before setting the PTE along with a wmb maybe to make sure it's visible > before the PTE no ?) Oops, good catch. You're right. We probably don't need a barrier because we take the ptl lock around setting the pte, and the only other readers who care should be ones that also take the same ptl lock. -- SUSE Labs, Novell Inc. Send instant messages to your online friends http://au.messenger.yahoo.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists