linux-kernel - [PATCH 2.6.19-rc1] drivers/media/video/se401.c: check kmalloc() return value.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Tue, 10 Oct 2006 23:23:30 -0700
From:	Amit Choudhary <amit2030@...il.com>
To:	Linux Kernel <linux-kernel@...r.kernel.org>
Subject: [PATCH 2.6.19-rc1] drivers/media/video/se401.c: check kmalloc()
 return value.

Description: Check the return value of kmalloc() in function se401_start_stream(), in file drivers/media/video/se401.c.

Signed-off-by: Amit Choudhary <amit2030@...il.com>

diff --git a/drivers/media/video/se401.c b/drivers/media/video/se401.c
index 7aeec57..20b91db 100644
--- a/drivers/media/video/se401.c
+++ b/drivers/media/video/se401.c
@@ -57,6 +57,7 @@ MODULE_PARM_DESC(flickerless, "Net frequ
 module_param(video_nr, int, 0);
 
 static struct usb_driver se401_driver;
+static int se401_stop_stream(struct usb_se401 *se401);
 
 
 /**********************************************************************
@@ -450,6 +451,11 @@ static int se401_start_stream(struct usb
 	}
 	for (i=0; i<SE401_NUMSBUF; i++) {
 		se401->sbuf[i].data=kmalloc(SE401_PACKETSIZE, GFP_KERNEL);
+		/* No memory, stop streaming */
+		if (!se401->sbuf[i].data) {
+			se401_stop_stream(se401);
+			return -ENOMEM;
+		}
 	}
 
 	se401->bayeroffset=0;
@@ -458,6 +464,11 @@ static int se401_start_stream(struct usb
 	se401->scratch_overflow=0;
 	for (i=0; i<SE401_NUMSCRATCH; i++) {
 		se401->scratch[i].data=kmalloc(SE401_PACKETSIZE, GFP_KERNEL);
+		/* No memory, stop streaming */
+		if (!se401->scratch[i].data) {
+			se401_stop_stream(se401);
+			return -ENOMEM;
+		}
 		se401->scratch[i].state=BUFFER_UNUSED;
 	}
 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/