linux-kernel - Re: [PATCH] rename net

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 13 Oct 2006 12:09:56 -0700
From:	Andrew Morton <akpm@...l.org>
To:	Adrian Bunk <bunk@...sta.de>
Cc:	Stephen Hemminger <shemminger@...l.org>,
	linux-kernel@...r.kernel.org,
	Stephane Eranian <eranian@....hp.com>, sam@...nborg.org
Subject: Re: [PATCH] rename net_random to random32

On Fri, 13 Oct 2006 20:19:22 +0200
Adrian Bunk <bunk@...sta.de> wrote:

> On Thu, Oct 12, 2006 at 10:26:38AM -0700, Stephen Hemminger wrote:
> > 
> > Make net_random() more widely available by calling it random32
> >...
> > --- a/lib/Makefile
> > +++ b/lib/Makefile
> > @@ -5,7 +5,7 @@ #
> >  lib-y := ctype.o string.o vsprintf.o cmdline.o \
> >  	 bust_spinlocks.o rbtree.o radix-tree.o dump_stack.o \
> >  	 idr.o div64.o int_sqrt.o bitmap.o extable.o prio_tree.o \
> > -	 sha1.o irq_regs.o carta_random32.o
> > +	 sha1.o irq_regs.o random32.o carta_random32.o
> >...
> > --- /dev/null
> > +++ b/lib/random32.c
> >...
> > +EXPORT_SYMBOL(random32);
> >...
> > +EXPORT_SYMBOL(srandom32);
> >...
> 
> EXPORT_SYMBOL's in lib-y are latent bugs (IMHO kbuild should error
> on them):
> 
> The problem is that if only modules use these functions, they will be 
> omitted from the kernel image.
> 

Yeah, I always get those two confused.  I moved it to obj-y, thanks.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/