linux-kernel - Re: [PATCH] x86_64 add missing enter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 16 Oct 2006 07:13:42 -0700
From:	Stephane Eranian <eranian@....hp.com>
To:	Andi Kleen <ak@...e.de>
Cc:	linux-kernel@...r.kernel.org, akpm@...l.org
Subject: Re: [PATCH] x86_64 add missing enter_idle() calls

Andi,

On Mon, Oct 16, 2006 at 12:08:13PM +0200, Andi Kleen wrote:
> On Friday 06 October 2006 10:16, Stephane Eranian wrote:
> > Hi,
> > 
> > Unless I am mistaken, I think we are missing some calls to enter_idle()
> > in the x86_64 tree. The following patch adds a bunch of missing
> > enter_idle() callbacks for some of the "direct" interrupt handlers.
> > 
> > changelog:
> > 	- adds missing enter_idle() calls to most of the "direct" interrupt
> > 	  handlers.
> 
> HLT returns after an interrupt and then does enter_idle()

With the original code, the number of callbacks you see for IDLE_START and
IDLE_STOP is not too obvious.

On an idle system Opteron 250 with HZ=250, one would expect to see for a 10s duration:
	- for CPU0      : IDLE_START = IDLE_STOP = about 5000 calls
	- for other CPUs: IDLE_START = IDLE_STOP = about 2500  calls

With the original code, you get the following number of calls:

CPU0.IDLE_START = 44 (enter_idle)
CPU0.IDLE_STOP  = 5206 (exit_idle)

CPU1.IDLE_START = 27 (enter_idle)
CPU1.IDLE_STOP  = 2528 (exit_idle)

Now, of course, you may get "batched" interrupts where you do not return to idle
before you process the next interrupt. But the difference seems quite high here.

Do you have an explanation for this?

-- 
-Stephane
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/