linux-kernel - Re: [Patch 4/4] Driver core: Don't fail attaching the device if it cannot be bound.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 17 Oct 2006 12:04:28 -0400 (EDT)
From:	Alan Stern <stern@...land.harvard.edu>
To:	Cornelia Huck <cornelia.huck@...ibm.com>
cc:	Greg K-H <greg@...ah.com>,
	Duncan Sands <duncan.sands@...h.u-psud.fr>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [Patch 4/4] Driver core: Don't fail attaching the device if it
 cannot be bound.

On Tue, 17 Oct 2006, Cornelia Huck wrote:

> From: Cornelia Huck <cornelia.huck@...ibm.com>
> 
> Don't fail bus_attach_device(), even if the device cannot be bound.
> 
> If dev->driver has been specified, reset it to NULL if device_bind_driver()
> failed and add the device as an unbound device. As a result, bus_attach_device()
> now cannot fail, and we can remove some checking from device_add().
> 
> Also remove an unneeded check in bus_rescan_devices_helper().

The other patches look good, and so does this one except for one small
thing:

> -int bus_attach_device(struct device * dev)
> +void bus_attach_device(struct device * dev)
>  {
>  	struct bus_type *bus = dev->bus;
> -	int ret = 0;
> +	int ret;
>  
>  	if (bus) {
>  		dev->is_registered = 1;
>  		ret = device_attach(dev);
> -		if (ret >= 0) {
> +		BUG_ON(ret < 0);
> +		if (ret >= 0)
>  			klist_add_tail(&dev->knode_bus, &bus->klist_devices);
> -			ret = 0;
> -		} else
> +		else
>  			dev->is_registered = 0;

It looks odd to test the value of ret when you've just crashed the system 
if ret < 0.  You probably should change the BUG_ON to a WARN_ON or 
something similar.

Alan Stern

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/