linux-kernel - Re: [PATCH 3/6] video: use bitrev8

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 20 Oct 2006 11:48:27 +0900
From:	Akinobu Mita <akinobu.mita@...il.com>
To:	Michael Tokarev <mjt@....msk.ru>
Cc:	linux-kernel@...r.kernel.org, Antonino Daplas <adaplas@....net>
Subject: Re: [PATCH 3/6] video: use bitrev8

On Thu, Oct 19, 2006 at 01:29:49PM +0400, Michael Tokarev wrote:
> >  static inline void reverse_order(u32 *l)
> >  {
> >  	u8 *a = (u8 *)l;
> > -	*a = byte_rev[*a], a++;
> > -	*a = byte_rev[*a], a++;
> > -	*a = byte_rev[*a], a++;
> > -	*a = byte_rev[*a];
> > +	a[0] = bitrev8(a[0]);
> > +	a[1] = bitrev8(a[1]);
> > +	a[2] = bitrev8(a[2]);
> > +	a[3] = bitrev8(a[3]);
> >  }
> 
> This looks like a good candidate for a common helper function, too.

I thought that and we already have static function bytereverse()
in lib/crc32. But I could not find where I could replace except here.
So I didn't put bytereverse() into bitrev.h

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/