linux-kernel - Hopefully, kmalloc() will always succeed, but if it doesn't then....

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 22 Oct 2006 12:58:08 -0700 (PDT)
From:	Amit Choudhary <amit2030@...oo.com>
To:	linux-kernel@...r.kernel.org
Subject: Hopefully, kmalloc() will always succeed, but if it doesn't then....

Hi All,

Hopefully, kmalloc() should always succeed. But if it doesn't then the kernel is going to crash
left and right. But I guess that there's no point in running if there is no memory. Anyways, here
is what I found at many places:

func()
{
   char *a; 
   char *b;

   a = kmalloc(10, GFP_KERNEL);
   if (!a)
       goto error;

   b = kmalloc(10, GFP_KERNEL);
   if (!b)
       goto error;

 error:
  kfree(a);
  kfree(b);

}

So, if memory allocation to 'a' fails, it is going to kfree 'b'. But since 'b' is not initialized,
 kfree may crash (unless DEBUG is defined).

I have seen the same case at many places when allocating in a loop.

Regards,
Amit 

__________________________________________________
Do You Yahoo!?
Tired of spam?  Yahoo! Mail has the best spam protection around 
http://mail.yahoo.com 
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/