linux-kernel - Re: [patch] input: function call order in serio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 22 Oct 2006 23:15:47 -0400
From:	Dmitry Torokhov <dtor@...ightbb.com>
To:	Németh Márton <nm127@...email.hu>
Cc:	linux-input@...ey.karlin.mff.cuni.cz, linux-kernel@...r.kernel.org
Subject: Re: [patch] input: function call order in serio_exit()

On Sunday 22 October 2006 11:45, Németh Márton wrote:
> Hi,
> 
> the order of the bus registration and the kthread start was changed
> between linux kernel 2.6.17.11 and 2.6.18. The order is now first
> register the bus and then start the kthread. The serio_exit() left
> unchanged.
> 
> I think that the order of the function calls in serio_exit() should also
> be changed: first stop the kthread and then unregister the bus.
> 
> What do you think?
> 

Hi,

It really does not matter - if bus is unregistered that means the there
are no drivers using it and so noone can submit new requests to kseriod.

I'd leave it as is.

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/