linux-kernel - RE: [PATCH] x86_64 irq: reuse vector for set_xxx_irq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 23 Oct 2006 13:00:23 -0700
From:	"Lu, Yinghai" <yinghai.lu@....com>
To:	ebiederm@...ssion.com
cc:	"Andi Kleen" <ak@....de>, "Muli Ben-Yehuda" <muli@...ibm.com>,
	"Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>,
	"Andrew Morton" <akpm@...l.org>, "Adrian Bunk" <bunk@...sta.de>
Subject: RE: [PATCH] x86_64 irq: reuse vector for set_xxx_irq_affinity
 in phys flat mode

From: ebiederm@...ssion.com [mailto:ebiederm@...ssion.com] 

>Beyond that I have a few nits to pick with the patch.
>- We duplicate the code that claims a new vector which makes
>  maintenance a pain.
>- The comments are specific to phys_flat but the code is not.
>- The test for being able to use the old_vector in the new domain
>  should be: ...[old_vector] == vector || ...[old_vector] == -1

Please attached one. This one need to after your patch about irq.

YH


Download attachment "io_apic_reuse_vector.diff" of type "application/octet-stream" (2306 bytes)