lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 24 Oct 2006 17:40:11 +1000 From: Benjamin Herrenschmidt <benh@...nel.crashing.org> To: linux1394-devel@...ts.sourceforge.net Cc: linuxppc-dev list <linuxppc-dev@...abs.org>, Linux Kernel list <linux-kernel@...r.kernel.org>, Greg KH <greg@...ah.com> Subject: Re: pci_set_power_state() failure and breaking suspend On Tue, 2006-10-24 at 16:54 +1000, Benjamin Herrenschmidt wrote: > So I noticed a small regression that I think might uncover a deeper > issue... > > Recently, ohci1394 grew some "proper" error handling in its suspend > function, something that looks like: > > err = pci_set_power_state(pdev, pci_choose_state(pdev, state)); > if (err) > goto out; > > First, it breaks some old PowerBooks where the internal OHCI had PM > feature exposed on PCI (the pmac specific code that follows those lines > is enough on those machines). If I could type, the above would have read... First, it breaks some old PowerBooks where the internal OHCI has no PM feature exposed on PCI.... Ben. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists