linux-kernel - Re: [PATCH] appletalk: prevent unregister_sysctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 24 Oct 2006 02:38:24 -0700 (PDT)
From:	David Rientjes <rientjes@...washington.edu>
To:	Akinobu Mita <akinobu.mita@...il.com>
cc:	linux-kernel@...r.kernel.org, akpm@...l.org,
	Arnaldo Carvalho de Melo <acme@...ectiva.com.br>
Subject: Re: [PATCH] appletalk: prevent unregister_sysctl_table() with a NULL
 argument

On Tue, 24 Oct 2006, Akinobu Mita wrote:

> If register_sysctl_table() fails during module initalization,
> NULL pointer dereference will happen in the module cleanup.
> 

The only way this would happen at atalk_unregister_sysctl is if the 
kmalloc failed on register_sysctl_table during init.  In that case there 
is no need to unregister atalk in the first place since it never came up, 
so this doesn't appear to be the correct fix.  Even if it were possible, 
this check should be done at atalk_exit instead of 
atalk_unregister_sysctl.

		David
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/