linux-kernel - Re: [PATCH 1/4] Prep for paravirt: Be careful about touching BIOS address space

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 29 Oct 2006 12:01:09 -0800
From:	Don Mullis <dwm@...r.net>
To:	Rusty Russell <rusty@...tcorp.com.au>
Cc:	Andrew Morton <akpm@...l.org>,
	lkml - Kernel Mailing List <linux-kernel@...r.kernel.org>,
	virtualization <virtualization@...ts.osdl.org>
Subject: Re: [PATCH 1/4] Prep for paravirt: Be careful about touching BIOS
	address space

Rusty Russell wrote:
> @@ -301,7 +302,7 @@ static struct pci_raw_ops pci_bios_acces
>  
>  static struct pci_raw_ops * __devinit pci_find_bios(void)
>  {
> -	union bios32 *check;
> +	union bios32 *check, sig;

This "sig" definition has no references, and is shadowed by the definition below.

> @@ -314,6 +315,10 @@ static struct pci_raw_ops * __devinit pc
>  	for (check = (union bios32 *) __va(0xe0000);
>  	     check <= (union bios32 *) __va(0xffff0);
>  	     ++check) {
> +		long sig;
> +		if (__get_user(sig, &check->fields.signature))

But, no complaint from gcc.  Trying to elicit a complaint by configuring
CC_OPTIMIZE_FOR_SIZE='n' breaks the build with:

  include/asm/desc.h: In function 'set_ldt':
  include/asm/desc.h:92: error: implicit declaration of function 'write_gdt_entry'

See reply to "[PATCH 3/4]" for a fix.

DM

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/