linux-kernel - Re: [PATCH 6/7] Add APIC accessors to paravirt-ops.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 29 Oct 2006 08:31:20 -0800
From:	Andi Kleen <ak@...e.de>
To:	virtualization@...ts.osdl.org
Cc:	Chris Wright <chrisw@...s-sol.org>, akpm@...l.org, ak@....de,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 6/7] Add APIC accessors to paravirt-ops.


>
>  /* nop stub */
>  static void native_nop(void)
> @@ -382,6 +384,26 @@ static fastcall void native_io_delay(voi
>  	asm volatile("outb %al,$0x80");
>  }
>
> +#ifdef CONFIG_X86_LOCAL_APIC

It would be nicer if you renamed the functions in apic.h to native_apic_*
and then do

#ifdef CONFIG_PARAVIRT
#include <asm/paravirt.h>
#else
#define apic_read native_apic_read
...
#endif

This way we wouldn't get that much duplication.

This might apply to at least some of the other paravirt ops too.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/