| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 30 Oct 2006 18:57:44 +0100 From: Ingo Molnar <mingo@...e.hu> To: Arjan van de Ven <arjan@...radead.org> Cc: Jens Axboe <jens.axboe@...cle.com>, Mark Lord <liml@....ca>, IDE/ATA development list <linux-ide@...r.kernel.org>, Linux Kernel <linux-kernel@...r.kernel.org> Subject: Re: 2.6.19-rc3-git7: scsi_device_unbusy: inconsistent lock state * Arjan van de Ven <arjan@...radead.org> wrote: > > struct rb_node *parent; > > struct cfq_io_context *__cic; > > + unsigned long flags; > > void *k; > > > > cic->ioc = ioc; > > @@ -1384,9 +1385,9 @@ restart: > > rb_link_node(&cic->rb_node, parent, p); > > rb_insert_color(&cic->rb_node, &ioc->cic_root); > > > > - spin_lock_irq(cfqd->queue->queue_lock); > > + spin_lock_irqsave(cfqd->queue->queue_lock, flags); > > list_add(&cic->queue_list, &cfqd->cic_list); > > - spin_unlock_irq(cfqd->queue->queue_lock); > > + spin_unlock_irqrestore(cfqd->queue->queue_lock, flags); > > } > > this looks entirely reasonable and correct > > Acked-By: Arjan van de Ven <arjan@...ux.intel.com> yep. Acked-by: Ingo Molnar <mingo@...e.hu> Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists