linux-kernel - Re: CONFIG_USB_USBNET and mii

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 31 Oct 2006 09:11:55 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Athanasius <link@...gy.org>
Cc:	Linus Torvalds <torvalds@...l.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	toralf.foerster@....de, netdev@...r.kernel.org,
	linux-usb-devel@...ts.sourceforge.net, greg@...ah.com,
	akpm@...l.org, zippel@...ux-m68k.org,
	dbrownell@...rs.sourceforge.net
Subject: Re: CONFIG_USB_USBNET and mii_* (was Re: Linux 2.6.19-rc4)

On Tue, 31 Oct 2006 17:02:09 +0000 Athanasius wrote:

> On Mon, Oct 30, 2006 at 08:27:17PM -0800, Linus Torvalds wrote:
> > Before I forget, I'd like to thank Adrian Bunk for his regressions 
> > listings, and ask people who are involved with those (both on the blamer 
> > and blamee sides) to follow them, and keep making sure that we get them 
> > resolved - if only by reminding people about the issues, and testing that 
> > things that are claimed to be resolved really are.
> 
>   In that light, although it's not being counted as a regression, my
> report about CONFIG_USB_USBNET stuff starting to make use of mii_* stuff
> in 19-rc3, without making SURE it's available is still outstanding,
> unfixed, in 19-rc4 (checked just now by untarring a fresh 2.6.18 copy,
> applying the rc4 patch, copying in the known-broken .config from rc3,
> make oldconfig, then my usual make bzImage && make modules).
>   I've pootled around 'make menuconfig' as well, 'N' and then re-Y/M'ing
> USBNET things and it has no effect on the PHYLIB stuff.

It's actually CONFIG_MII, not PHYLIB.

Probably David B. needs to resend patch 2/2.
They seem to have been lost in the noise^W recent travel.

Patch 1/2 is below.


>   I know patches were flying around in the discussion, have none of them
> been shaken down sufficiently for inclusion or has the final patch
> simply not been pushed to/seen by Linus yet?
> 
>   'Ironically' I don't actually _use_ the usbnet stuff, I'd only enabled
> it in case my gf pestered me to test her bluetooth dongle for some
> reason.  Thus I'm only likely to keep tabs on this if I specifically
> think to, it won't show up in my normal usage patterns.

---
From: Randy Dunlap <randy.dunlap@...cle.com>

pegasus and mcs7830 drivers use MII interfaces and should
select MII in the same way that drivers/net/ drivers do.

However, the MII config symbol should not be in the 10/100 Ethernet
menu, so that other drivers can use (enable) it or so that users
can enable it without needing to enable 10/100 Ethernet.

Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
---
 drivers/net/Kconfig     |   15 +++++++--------
 drivers/usb/net/Kconfig |    2 ++
 2 files changed, 9 insertions(+), 8 deletions(-)

--- linux-2619-rc3-pv.orig/drivers/usb/net/Kconfig
+++ linux-2619-rc3-pv/drivers/usb/net/Kconfig
@@ -84,6 +84,7 @@ config USB_PEGASUS
 config USB_RTL8150
 	tristate "USB RTL8150 based ethernet device support (EXPERIMENTAL)"
 	depends on EXPERIMENTAL
+	select MII
 	help
 	  Say Y here if you have RTL8150 based usb-ethernet adapter.
 	  Send me <petkan@...rs.sourceforge.net> any comments you may have.
@@ -210,6 +211,7 @@ config USB_NET_PLUSB
 config USB_NET_MCS7830
 	tristate "MosChip MCS7830 based Ethernet adapters"
 	depends on USB_USBNET
+	select MII
 	help
 	  Choose this option if you're using a 10/100 Ethernet USB2
 	  adapter based on the MosChip 7830 controller. This includes
--- linux-2619-rc3-pv.orig/drivers/net/Kconfig
+++ linux-2619-rc3-pv/drivers/net/Kconfig
@@ -145,6 +145,13 @@ config NET_SB1000
 
 source "drivers/net/arcnet/Kconfig"
 
+config MII
+	tristate "Generic Media Independent Interface device support"
+	help
+	  Most ethernet controllers have MII transceiver either as an external
+	  or internal device.  It is safe to say Y or M here even if your
+	  ethernet card lacks MII.
+
 source "drivers/net/phy/Kconfig"
 
 #
@@ -180,14 +187,6 @@ config NET_ETHERNET
 	  kernel: saying N will just cause the configurator to skip all
 	  the questions about Ethernet network cards. If unsure, say N.
 
-config MII
-	tristate "Generic Media Independent Interface device support"
-	depends on NET_ETHERNET
-	help
-	  Most ethernet controllers have MII transceiver either as an external
-	  or internal device.  It is safe to say Y or M here even if your
-	  ethernet card lack MII.
-
 source "drivers/net/arm/Kconfig"
 
 config MACE

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/