linux-kernel - Re: [PATCH] init_reap_node() initialization fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	31 Oct 2006 22:25:53 +0100
From:	Andi Kleen <ak@...e.de>
To:	Daniel Yeisley <dan.yeisley@...sys.com>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] init_reap_node() initialization fix

Daniel Yeisley <dan.yeisley@...sys.com> writes:

> It looks like there is a bug in init_reap_node() in slab.c that can
> cause multiple oops's on certain ES7000 configurations.  The variable
> reap_node is defined per cpu, but only initialized on a single CPU.
> This causes an oops in next_reap_node() when __get_cpu_var(reap_node)
> returns the wrong value.  Fix is below.

Agreed. The cpu up call back is usually called on the BP only,
so __get_cpu_var which uses a local variable is wrong here.

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/