linux-kernel - Re: [PATCH -mm] replacement for broken kbuild-dont-put-temp-files-in-the-source-tree.patch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 31 Oct 2006 01:27:57 +0100
From:	Horst Schirmeier <horst@...irmeier.com>
To:	Oleg Verych <olecom@...wer.upol.cz>
Cc:	Valdis.Kletnieks@...edu, Jan Beulich <jbeulich@...ell.com>,
	dsd@...too.org, kernel@...too.org, draconx@...il.com,
	jpdenheijer@...il.com, Andrew Morton <akpm@...l.org>,
	Sam Ravnborg <sam@...nborg.org>, Andi Kleen <ak@...e.de>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -mm] replacement for broken kbuild-dont-put-temp-files-in-the-source-tree.patch

On Mon, 30 Oct 2006, Oleg Verych wrote:
> +# Immortal null for mortals and roots
> +define null
> +  $(shell \
> +    if test -L null; \
> +      then echo null; \
> +      else rm -f null; ln -s /dev/null null; \
> +    fi)
> +endef

Another remark: the 'else' branch should echo null, too.

# Immortal null for mortals and roots
define null
  $(shell \
    if test ! -L null; \
      then rm -f null; ln -s /dev/null null; \
    fi; \
    echo null)
endef

My patch proposal (the $(M) one) has the same bug.

Kind regards,
 Horst

-- 
PGP-Key 0xD40E0E7A
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/