linux-kernel - Re: [KJ][PATCH] Correct misc_register return code handling in several drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 2 Nov 2006 01:05:49 +0100
From:	"Jesper Juhl" <jesper.juhl@...il.com>
To:	"Neil Horman" <nhorman@...driver.com>
Cc:	"Benjamin Herrenschmidt" <benh@...nel.crashing.org>, akpm@...l.org,
	kernel-janitors@...ts.osdl.org, kjhall@...ibm.com,
	maxk@...lcomm.com, linux-kernel@...r.kernel.org
Subject: Re: [KJ][PATCH] Correct misc_register return code handling in several drivers

On 01/11/06, Neil Horman <nhorman@...driver.com> wrote:
> Hey all-
>         Since Andrew hasn't incorporated this patch yet, and I had the time, I
> redid the patch taking Benjamin's INIT_LIST_HEAD and Joes mmtimer cleanup into
> account.  New patch attached, replacing the old one, everything except the
> aforementioned cleanups is identical.
>
> Thanks & Regards
> Neil
>
> Signed-off-by: Neil Horman <nhorman@...driver.com>
>
> +out4:
> +       for_each_online_node(node) {
> +               kfree(timers[node]);
> +       }
> +out3:
> +       misc_deregister(&mmtimer_miscdev);
> +out2:
> +       free_irq(SGI_MMTIMER_VECTOR, NULL);
> +out1:
> +       return -1;

Very nitpicky little thing, but shouldn't the labels start at column
1, not column 0 ?
I thought that was standard practice (apparently labels at column 0
can confuse 'patch').

Hmm, I guess that should be defined once and for all in
Documentation/CodingStyle

-- 
Jesper Juhl <jesper.juhl@...il.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/