linux-kernel - Re: [RFT/PATCH] i8042: remove polling timer (v6)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 3 Nov 2006 00:56:02 -0500
From:	Dmitry Torokhov <dtor@...ightbb.com>
To:	Dave Neuer <mr.fred.smoothie@...ox.com>
Cc:	Vojtech Pavlik <vojtech@...e.cz>,
	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>
Subject: Re: [RFT/PATCH] i8042: remove polling timer (v6)

On Monday 30 October 2006 09:22, Dave Neuer wrote:
> On 10/30/06, Dave Neuer <mr.fred.smoothie@...ox.com> wrote:
> >
> > Maybe I'm missing something, (well actually I'm sure I'm missing
> > somethng). Looking at the code again, it's unclear to me why there is
> > even a call to the ISR in i8042_aux_write, since the latter function
> > already calls i8042_read_data.
> >
> 
> Whoops, sorry. I meant i8042_command, which is called by
> i8042_aux_write before the call to i8042_interrupt, already calls
> i8042_read_data.
>

It only calls i8042_read_data() if command is supposed to return data.
Neither I8042_CMD_AUX_SEND nor I8042_CMD_MUX_SEND wait fotr data to come
back.

Anyway, I removed call to i8042_interrupt() from i8042_aux_write() because
it is indeed unnecessary.

-- 
Dmitry
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/