linux-kernel - Re: [PATCH 6/12] repost: cciss: set sector

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 6 Nov 2006 21:30:02 +0100
From:	Jens Axboe <jens.axboe@...cle.com>
To:	"Mike Miller (OS Dev)" <mikem@...rdog.cca.cpqcorp.net>
Cc:	akpm@...l.org, linux-kernel@...r.kernel.org,
	linux-scsi@...r.kernel.org
Subject: Re: [PATCH 6/12] repost: cciss: set sector_size to 2048 for performance

On Mon, Nov 06 2006, Mike Miller (OS Dev) wrote:
> PATCH 6/11
> 
> This patch changes the blk_queue_max_sectors from 512 to 2048. This helps
> increase performance.
> Please consider this for inclusion.

Bad naming - I've never seen sector size refer to anything else but the
actual sector size on the device. Here you use it as the largest
supported command size. To make matters worse, you also export it in the
proc file as such, that's certain to confuse users.

In other news, ack on patch 1-5 so far.

-- 
Jens Axboe

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/