linux-kernel - Re: + net-uninline-skb_put.patch added to -mm tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 06 Nov 2006 14:42:33 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	linux-kernel@...r.kernel.org, akpm@...l.org
Cc:	acme@...ectiva.com.br
Subject: Re: + net-uninline-skb_put.patch added to -mm tree

From: akpm@...l.org
Date: Fri, 03 Nov 2006 14:18:29 -0800

> Subject: net: uninline skb_put()
> From: Andrew Morton <akpm@...l.org>
> 
> It has 34 callsites for a total of 2650 bytes.
> 
> Cc: Arnaldo Carvalho de Melo <acme@...ectiva.com.br>
> Signed-off-by: Andrew Morton <akpm@...l.org>

A more accurate figure would probably be:

davem@...set:~/src/GIT/net-2.6$ git grep skb_put | grep -v __skb_put | wc -l
1167

:-)

Half of the cost of this interface are the assertions, which while
useful are obviously over the top for such an oft-used routine in
packet processing.

Without the assertion checks it's merely:

	unsigned char *tmp = skb->tail;
	skb->tail += len;
	skb->len  += len;
	return tmp;

And even with 1167 call sites that is definitely something which
should be inlined.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/