linux-kernel - Re: [PATCH 1/8] Char: istallion, convert to pci probing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 3 Nov 2006 19:19:45 +0100
From:	Rolf Eike Beer <eike-kernel@...tec.de>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	Andrew Morton <akpm@...l.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/8] Char: istallion, convert to pci probing

Jiri Slaby wrote:
> istallion, convert to pci probing
>
> Use probing for pci devices. Change some __inits to __devinits to use these
> functions in probe function. Create stli_cleanup_ports and move there
> cleanup code from module_exit() code to not have duplicite cleanup code.
>
> Signed-off-by: Jiri Slaby <jirislaby@...il.com>
>
> ---
> commit b90798585707a33d1835b752a18f1ca3b6a7da7b
> tree 7c99e2bcca81b25dc3ffdcf288b5a9c35433c098
> parent 7e8fb7980d776e6a7c0bd84cc48b1cb9de139b8f
> author Jiri Slaby <jirislaby@...il.com> Sun, 29 Oct 2006 23:37:48 +0100
> committer Jiri Slaby <jirislaby@...il.com> Sat, 04 Nov 2006 18:26:39 +0059
>
>  drivers/char/istallion.c |  116
> +++++++++++++++++++++++++++------------------- 1 files changed, 67
> insertions(+), 49 deletions(-)
>
> diff --git a/drivers/char/istallion.c b/drivers/char/istallion.c
> index f07716b..9e73d0d 100644
> --- a/drivers/char/istallion.c
> +++ b/drivers/char/istallion.c
> @@ -402,7 +402,6 @@ static int	stli_eisamempsize = ARRAY_SIZ
>  /*
>   *	Define the Stallion PCI vendor and device IDs.
>   */
> -#ifdef CONFIG_PCI
>  #ifndef	PCI_VENDOR_ID_STALLION
>  #define	PCI_VENDOR_ID_STALLION		0x124d
>  #endif

Remove that ifdef and define too. We _have_ the id in include/linux/pci_ids.h

Eike

Content of type "application/pgp-signature" skipped