linux-kernel - Re: [PATCH 2/2] Workaround for SB600 SATA ODD issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 08 Nov 2006 08:30:25 -0500
From:	Jeff Garzik <jeff@...zik.org>
To:	Luugi Marsan <luugi.marsan@....com>
CC:	linux-kernel@...r.kernel.org,
	"linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>
Subject: Re: [PATCH 2/2] Workaround for SB600 SATA ODD issue

Luugi Marsan wrote:
> From: conke.hu@....com
> 
> There was an ASIC bug in the SB600 SATA controller of low revision (<=13) and CD burning may hang (only SATA ODD has this issue, and SATA HDD works well). The patch provides a workaround for this issue.
> 
> Signed-off-by:  Luugi Marsan <luugi.marsan@....com>

ACK technical content, but it needs one revision:  like someone else 
(Alan or Tejun?) mentioned, this patch should be revised to use a 
separate ata_port_operations for the affected chip(s).

Copy ahci_ops to sb600_ops, add your check-atapi-dma function without 
the vendor/device ID check.  Move the vendor/device check to the 
pci_device_id table by creating a board_ahci_sb600 constant and 
associated table data.

I agree with other posters that we should move the revision check to 
more generic code, but such a move should not block this patch.  The two 
efforts can occur in parallel.

	Jeff

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/