lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 14 Nov 2006 02:46:28 +0100 From: Andi Kleen <ak@...e.de> To: vgoyal@...ibm.com Cc: linux kernel mailing list <linux-kernel@...r.kernel.org>, Reloc Kernel List <fastboot@...ts.osdl.org>, ebiederm@...ssion.com, akpm@...l.org, hpa@...or.com, magnus.damm@...il.com, lwang@...hat.com, dzickus@...hat.com Subject: Re: [RFC] [PATCH 2/16] x86_64: Assembly safe page.h and pgtable.h > > I think we need these UL suffixes. Otherwise in some cases overflow > can take place and compiler emits warning. > > For ex. in following definition I got rid of UL. > > #define PGDIR_SIZE (1 << PGDIR_SHIFT) Yes for the shifts it is needed, but not for the unshifted constants. I think. At least when they're hex the compiler should chose the right type on its own. -Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists