linux-kernel - Re: [patch] sched: optimize activate_task for RT task

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 15 Nov 2006 09:24:06 +0100
From:	Mike Galbraith <efault@....de>
To:	"Chen, Kenneth W" <kenneth.w.chen@...el.com>
Cc:	nickpiggin@...oo.com.au, 'Ingo Molnar' <mingo@...e.hu>,
	"Siddha, Suresh B" <suresh.b.siddha@...el.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [patch] sched: optimize activate_task for RT task - v2

On Wed, 2006-11-15 at 08:00 +0100, Mike Galbraith wrote:

> Personally, I think it's best to leave it as it is.  With that change,
> if someone changes policy while the task is waiting to get cpu, it will
> be requeued, and the on-runqueue bonus logic will then end up using
> wildly inaccurate information.

Bah, that's inverted.  interactive_sleep() will never be true after a
rt->non-rt policy change while enqueued with your change, so on-runqueue
bonus will be disabled where it otherwise might have been enabled.  Not
terribly interesting in any case given the likelihood, but still...

	-Mike

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/