linux-kernel - Re: [KJ][PATCH] Correct misc_register return code handling in several drivers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 15 Nov 2006 10:05:35 +0100
From:	"Jesper Juhl" <jesper.juhl@...il.com>
To:	"Randy Dunlap" <randy.dunlap@...cle.com>
Cc:	"Andrew Morton" <akpm@...l.org>,
	"Neil Horman" <nhorman@...driver.com>,
	"Benjamin Herrenschmidt" <benh@...nel.crashing.org>,
	kernel-janitors@...ts.osdl.org, kjhall@...ibm.com,
	maxk@...lcomm.com, linux-kernel@...r.kernel.org
Subject: Re: [KJ][PATCH] Correct misc_register return code handling in several drivers

On 15/11/06, Randy Dunlap <randy.dunlap@...cle.com> wrote:
> On Wed, 1 Nov 2006 17:22:41 -0800 Randy Dunlap wrote:
>
> > On Thu, 2 Nov 2006 02:23:42 +0100 Jesper Juhl wrote:
> >
...
> > >
> > > Signed-off-by: Jesper Juhl <jesper.juhl@...il.com>
> > > ---
> > >
> > > diff --git a/Documentation/CodingStyle b/Documentation/CodingStyle
> > > index 29c1896..4f6b2d5 100644
> > > --- a/Documentation/CodingStyle
> > > +++ b/Documentation/CodingStyle
> > > @@ -566,6 +566,21 @@ result.  Typical examples would be funct
> > >  NULL or the ERR_PTR mechanism to report failure.
> > >
> > >
> > > +           Chapter 17: Labels
> > > +
> > > +Label names should be lowercase.
> > > +
> > > +Label names should start with a letter [a-z].
> > > +
> > > +Labels should not be placed at column 0. Doing so confuses some tools, most
> > > +notably 'diff' and 'patch'. Instead place labels at column 1 (indented 1
> > > +space). In some cases it's OK to indent labels one or more tabs, but
> > > +generally it is preferred that labels be placed at column 1.
> > > +
> > > +Labels should stand out - be easily visible. They should not be indented so
> > > +much that they are hidden or obscured by the surrounding source code.
> > > +
> > > +
> > >
> > >             Appendix I: References
> >
> > Yep, OK with me.  (Ack)
> > ---
>
> Did Andrew ever pick up this doc. patch?
>
Not as far as I know.


> Anyway, I wanted to see the problem with 'diff' and labels in column 0
> causing 'diff -p' @@ tags to be confused, but when I tested it,
> it Works For Me.  No difference in diff @@ tags if I indent the
> labels or not.  or is this too simple?

I must admit that I've not been able to cause a failure either, an
example would be nice.

-- 
Jesper Juhl <jesper.juhl@...il.com>
Don't top-post  http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please      http://www.expita.com/nomime.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/