linux-kernel - Re: [Linux-fbdev-devel] Fwd: [Suspend-devel] resume not working on acer ferrari 4005 with radeonfb enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 Nov 2006 12:48:27 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Christian Hoffmann <chrmhoffmann@...il.com>
Cc:	linux-fbdev-devel@...ts.sourceforge.net,
	"Rafael J. Wysocki" <rjw@...k.pl>,
	Christian Hoffmann <Christian.Hoffmann@...lstreetsystems.com>,
	Andrew Morton <akpm@...l.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Solomon Peachy <pizza@...ftnet.org>,
	Pavel Machek <pavel@....cz>
Subject: Re: [Linux-fbdev-devel] Fwd: [Suspend-devel] resume not working on
	acer ferrari 4005 with radeonfb enabled

On Wed, 2006-11-15 at 01:54 +0100, Christian Hoffmann wrote:
> On Tuesday 14 November 2006 23:07, Benjamin Herrenschmidt wrote:
> > > I tried that patch, but the last message I see over netconsole (using
> > > tg3) is: Suspending console(s)
> > > and then nothing. Nothing on resume at all :(
> > >
> > > Adding some printks in the radeonfb_pci_suspend and radeonfb_pci_resume
> > > (radeon_pm.c) didn't help: I don't see them. But I am not a kernel
> > > programmer at all, so I might do something wrong or in the wrong place.
> >
> > Does it resume if you make radeon_pci_resume() a nop ?
> >
> > Of course, the fbdev will not come back, but will the machine overall
> > resume ?
> >
> > Ben.
> Yes, if i make radeon_pci_resume a nop, the machine resumes if i do a return 0 
> immediately.
> I think I tracked it down to the call to acquire_console_sem() as the 
> following code makes the machine hang again:
> 
> int radeonfb_pci_resume(struct pci_dev *pdev)
> {
>         struct fb_info *info = pci_get_drvdata(pdev);
>         struct radeonfb_info *rinfo = info->par;
>         int rc = 0;
>         if (pdev->dev.power.power_state.event == PM_EVENT_ON)
>                 return 0;
>         if (rinfo->no_schedule) {
>         /*      if (try_acquire_console_sem())*/
>                         return 0;
>         } else
>                 acquire_console_sem();
> 
>         return 0;
> ...

Well, if you acquire the console sem you need to release it too :-)

Ben.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/