linux-kernel - [PATCH 23/19] FS-Cache: NFS: Don't invoke FS-Cache from nfs_zap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 15 Nov 2006 16:42:56 +0000
From:	David Howells <dhowells@...hat.com>
To:	trond.myklebust@....uio.no, torvalds@...l.org, akpm@...l.org,
	sds@...ho.nsa.gov
Cc:	dhowells@...hat.com, selinux@...ho.nsa.gov,
	linux-kernel@...r.kernel.org, aviro@...hat.com, steved@...hat.com
Subject: [PATCH 23/19] FS-Cache: NFS: Don't invoke FS-Cache from nfs_zap_caches()


Don't invoke FS-Cache from nfs_zap_caches() as that is supposed to be quick
whereas FS-Cache may get semaphores and other sleepy things.

As it happens, the cache will be zapped upon the next revalidation anyway, and
so this is probably unnecessary.

Signed-Off-By: David Howells <dhowells@...hat.com>
---

 fs/nfs/inode.c |    2 --
 1 files changed, 0 insertions(+), 2 deletions(-)

diff --git a/fs/nfs/inode.c b/fs/nfs/inode.c
index 0d683eb..25376a5 100644
--- a/fs/nfs/inode.c
+++ b/fs/nfs/inode.c
@@ -130,8 +130,6 @@ void nfs_zap_caches(struct inode *inode)
 	spin_lock(&inode->i_lock);
 	nfs_zap_caches_locked(inode);
 	spin_unlock(&inode->i_lock);
-
-	nfs_fscache_zap_fh_cookie(inode);
 }
 
 void nfs_zap_mapping(struct inode *inode, struct address_space *mapping)
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/