linux-kernel - Re: reiserfs NET=n build error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 19 Nov 2006 06:50:49 +0100
From:	Andi Kleen <ak@...e.de>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	lkml <linux-kernel@...r.kernel.org>, reiserfs-dev@...esys.com,
	sam@...nborg.org, Jeff Mahoney <jeffm@...e.com>,
	Al Viro <viro@....linux.org.uk>
Subject: Re: reiserfs NET=n build error

On Sunday 19 November 2006 05:22, Randy Dunlap wrote:
> With CONFIG_NET=n and REISERFS_FS=m (randconfig), kernel build ends with
> 
> Kernel: arch/x86_64/boot/bzImage is ready  (#15)
>   Building modules, stage 2.
>   MODPOST 137 modules
> WARNING: "csum_partial" [fs/reiserfs/reiserfs.ko] undefined!
> make[1]: *** [__modpost] Error 1
> make: *** [modules] Error 2
> 
> on both 2.6.19-rc6 and 2.6.19-rc6-git2.
> 
> Looks like arch/x86_64/lib/lib.a is not being linked into the
> final kernel image for some reason.  lib.a does contain csum_partial.

iirc Al Viro has been cleaning that up. Essentially reiserfs should
use its own C copy of the checksum functions. Using csum_partial() is not
safe because its output varies by architecture.

I would copy a relatively simple C implementation, like arch/h8300/lib/checksum.c

-Andi
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/