linux-kernel - Re: [patch] PM: suspend/resume debugging should depend on SOFTWARE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 19 Nov 2006 09:29:21 +0100
From:	Pavel Machek <pavel@....cz>
To:	Chuck Ebbert <76306.1226@...puserve.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...l.org>,
	Linus Torvalds <torvalds@...l.org>,
	"Rafael J. Wysocki" <rjw@...k.pl>
Subject: Re: [patch] PM: suspend/resume debugging should depend on SOFTWARE_SUSPEND

Hi!

> When doing 'make oldconfig' we should ask about suspend/resume
> debug features when SOFTWARE_SUSPEND is not enabled.

These are suspend-to-ram debugging features, mostly, so no, they
should not depend on software suspend.

NAK. 

> Signed-off-by: Chuck Ebbert <76306.1226@...puserve.com>
> 
> --- 2.6.19-rc6-32.orig/kernel/power/Kconfig
> +++ 2.6.19-rc6-32/kernel/power/Kconfig
> @@ -38,7 +38,7 @@ config PM_DEBUG
>  
>  config DISABLE_CONSOLE_SUSPEND
>  	bool "Keep console(s) enabled during suspend/resume (DANGEROUS)"
> -	depends on PM && PM_DEBUG
> +	depends on PM_DEBUG && SOFTWARE_SUSPEND
>  	default n
>  	---help---
>  	This option turns off the console suspend mechanism that prevents
> @@ -49,7 +49,7 @@ config DISABLE_CONSOLE_SUSPEND
>  
>  config PM_TRACE
>  	bool "Suspend/resume event tracing"
> -	depends on PM && PM_DEBUG && X86_32 && EXPERIMENTAL
> +	depends on PM_DEBUG && SOFTWARE_SUSPEND && X86_32 && EXPERIMENTAL
>  	default n
>  	---help---
>  	This enables some cheesy code to save the last PM event point in the

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/