linux-kernel - Re: make menuconfig regression in 2.6.19-rc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 21 Nov 2006 00:36:10 +0100 (CET)
From:	Roman Zippel <zippel@...ux-m68k.org>
To:	Phil Oester <kernel@...uxace.com>
cc:	linux-kernel@...r.kernel.org
Subject: Re: make menuconfig regression in 2.6.19-rc

Hi,

On Mon, 13 Nov 2006, Phil Oester wrote:

> In commit 350b5b76384e77bcc58217f00455fdbec5cac594, the default menuconfig
> color scheme was changed to bluetitle.  This breaks the highlighting
> of the selected item for me with TERM=vt100.  The only way I can see
> which item is selected is via:
> 
>     make MENUCONFIG_COLOR=mono menuconfig
> 
> Which restores the pre-2.6.19 white on black highlighting.  

Could you try the patch below?

bye, Roman

---
 scripts/kconfig/lxdialog/util.c |   16 +++++++---------
 1 file changed, 7 insertions(+), 9 deletions(-)

Index: linux-2.6-mm/scripts/kconfig/lxdialog/util.c
===================================================================
--- linux-2.6-mm.orig/scripts/kconfig/lxdialog/util.c
+++ linux-2.6-mm/scripts/kconfig/lxdialog/util.c
@@ -221,16 +221,14 @@ static void init_dialog_colors(void)
  */
 static void color_setup(const char *theme)
 {
-	if (set_theme(theme)) {
-		if (has_colors()) {	/* Terminal supports color? */
-			start_color();
-			init_dialog_colors();
-		}
-	}
-	else
-	{
+	int use_color;
+
+	use_color = set_theme(theme);
+	if (use_color && has_colors()) {
+		start_color();
+		init_dialog_colors();
+	} else
 		set_mono_theme();
-	}
 }
 
 /*
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/