linux-kernel - Re: [PATCH] Add IDE mode support for SB600 SATA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sat, 25 Nov 2006 10:43:33 +0900
From:	Tejun Heo <htejun@...il.com>
To:	Alan <alan@...rguk.ukuu.org.uk>
CC:	Conke Hu <conke.hu@....com>, linux-kernel@...r.kernel.org,
	Andrew Morton <akpm@...l.org>, Jeff Garzik <jeff@...zik.org>,
	arjan@...radead.org
Subject: Re: [PATCH] Add IDE mode support for SB600 SATA

Alan wrote:
>> * Unlike Jmicron's case, this doesn't affect PCI bus scan.  Actually, it 
>> does change class code but that's not as disruptive as Jmicron's case 
>> and as long as ahci ignores class code, it doesn't really matter. 
>> Driver can be chosen by changing loading order - this is both plus and 
>> minus.
> 
> The load order is basically undefined. You want AHCI so we should do
> this early. That means either putting the same gunk all over the kernel
> (drivers/ide, drivers/ata/*ati* drivers/ata/ahci) or in one place.
>  
>> * As Arjan pointed out, that unlock-modify-lock sequence should be done 
>> on resume too.  
> 
> The infrastructure for this is already handled by the pci resume quirk
> patches I sent. 

As long as resume is properly handled, no problem.

Thanks.

-- 
tejun
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/