lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 27 Nov 2006 10:35:12 +0100 From: Cornelia Huck <cornelia.huck@...ibm.com> To: Greg K-H <greg@...ah.com> Cc: Andrew Morton <akpm@...l.org>, linux-kernel <linux-kernel@...r.kernel.org> Subject: [Patch 5/7] driver core: Change function call order in device_bind_driver(). From: Cornelia Huck <cornelia.huck@...ibm.com> Change function call order in device_bind_driver(). If we create symlinks (which might fail) before adding the device to the list we don't have to clean up afterwards (which we didn't). Signed-off-by: Cornelia Huck <cornelia.huck@...ibm.com> --- drivers/base/dd.c | 8 ++++++-- 1 files changed, 6 insertions(+), 2 deletions(-) --- linux-2.6-CH.orig/drivers/base/dd.c +++ linux-2.6-CH/drivers/base/dd.c @@ -86,8 +86,12 @@ static void driver_sysfs_remove(struct d */ int device_bind_driver(struct device *dev) { - driver_bound(dev); - return driver_sysfs_add(dev); + int ret; + + ret = driver_sysfs_add(dev); + if (!ret) + driver_bound(dev); + return ret; } struct stupid_thread_structure { - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists