linux-kernel - Re: [GFS2] Fix Kconfig wrt CRC32 [8/9]

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 28 Nov 2006 10:33:34 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Steven Whitehouse <swhiteho@...hat.com>
CC:	Patrick Caulfield <pcaulfie@...hat.com>,
	linux-kernel@...r.kernel.org, cluster-devel@...hat.com,
	Toralf Förster <toralf.foerster@....de>
Subject: Re: [GFS2] Fix Kconfig wrt CRC32 [8/9]

Steven Whitehouse wrote:
> Hi,
> 
> On Mon, 2006-11-27 at 08:38 -0800, Randy Dunlap wrote:
>> Steven Whitehouse wrote:
>>> Hi,
>>>
>>> On Fri, 2006-11-24 at 21:43 -0800, Randy Dunlap wrote:
>>>> On Fri, 24 Nov 2006 09:34:49 +0000 Steven Whitehouse wrote:
>>>>
>>>>> >From 6f788fd00c82533d4cd5587a9706f8468658a24d Mon Sep 17 00:00:00 2001
>>>>> From: Steven Whitehouse <swhiteho@...hat.com>
>>>>> Date: Mon, 20 Nov 2006 10:04:49 -0500
>>>>> Subject: [PATCH] [GFS2] Fix Kconfig wrt CRC32
>>>>> Content-Type: text/plain; charset=UTF-8
>>>>> Content-Transfer-Encoding: 8bit
>>>>>
>>>>> GFS2 requires the CRC32 library function. This was reported by
>>>>> Toralf Förster.
>>>>>
>>>>> Cc: Toralf Förster <toralf.foerster@....de>
>>>>> Signed-off-by: Steven Whitehouse <swhiteho@...hat.com>
>>>>> ---
>>>>>  fs/gfs2/Kconfig |    1 +
>>>>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>>>>
>>>>> diff --git a/fs/gfs2/Kconfig b/fs/gfs2/Kconfig
>>>>> index 8c27de8..c0791cb 100644
>>>>> --- a/fs/gfs2/Kconfig
>>>>> +++ b/fs/gfs2/Kconfig
>>>>> @@ -2,6 +2,7 @@ config GFS2_FS
>>>>>  	tristate "GFS2 file system support"
>>>>>  	depends on EXPERIMENTAL
>>>>>  	select FS_POSIX_ACL
>>>>> +	select CRC32
>>>>>  	help
>>>>>  	A cluster filesystem.
>>>> Hi,
>>>>
>>>> Do you also have Kconfig patches for DLM needing SYSFS
>>>> and DLM needing CONFIG_NET ?
>>>>
>>>> ---
>>>> ~Randy
>>> My original reply to this seemed to disappear into my email system
>>> somewhere, so apologies if this is the second copy you get.
>>>
>>> The DLM shouldn't depend upon SYSFS at all. I believe that its perfectly
>>> ok whether or not thats compiled in. There is a patch relating to the
>>> Kconfig for DLM which is in my -nmw tree:
>> Hm, OK.  Apparently I meant CONFIGFS instead of SYSFS.
>>
> The Kconfig for DLM in Linus' current tree says:
> 	select CONFIGFS_FS
> 
> so I don't know what else is needed.... its the same in -nmw as that bit
> hasn't changed.
> 
>>> http://www.kernel.org/git/?p=linux/kernel/git/steve/gfs2-2.6-nmw.git;a=commitdiff;h=8758fbc8724c2da8a6a062f2b61d79c8f2a55c5f
>>>
>>> This applies after the patch adding the TCP communications layer to DLM
>>> which is also in -nmw. The patches in -nmw (next merge window) are a
>>> superset of the ones I just requested that Linus pull since it contains
>>> the newer features and more involved bug fixes and clean ups.
>>>
>>> I believe that the Kconfig in -nmw is correct for DLM, though I'm
>>> willing to be proved wrong. I'm also copying in Patrick in case he wants
>>> to comment further as its more his area than mine,
>> I applied just that one patch to 2.6.19-rc6-git10 (which may or may not
>> be sufficient -- please say) and built with my previously failing config file.
> You'll need the patch:
> http://www.kernel.org/git/?p=linux/kernel/git/steve/gfs2-2.6-nmw.git;a=commitdiff;h=4a28fda50d864ede7d2724723949407e0e4043b8
> as well. I'm also slightly surprised that you managed to get the errors
> that you did, since most of those symbols appear to be networking
> related and the DLM depends on INET which is clearly not set since NET
> is not set.

Thanks, I'll apply that patch also and test again.

Part of the problem (IMO) is that kconfig s/w doesn't follow dependency
chains when applying "select"s.

>> It still fails with:
>>
>> WARNING: "kernel_sendmsg" [fs/dlm/dlm.ko] undefined!
>> WARNING: "sock_release" [fs/dlm/dlm.ko] undefined!
>> WARNING: "config_item_put" [fs/dlm/dlm.ko] undefined!
>> WARNING: "sock_create_kern" [fs/dlm/dlm.ko] undefined!
>> WARNING: "config_item_init_type_name" [fs/dlm/dlm.ko] undefined!
>> WARNING: "config_group_init_type_name" [fs/dlm/dlm.ko] undefined!
>> WARNING: "configfs_register_subsystem" [fs/dlm/dlm.ko] undefined!
>> WARNING: "config_group_find_obj" [fs/dlm/dlm.ko] undefined!
>> WARNING: "configfs_unregister_subsystem" [fs/dlm/dlm.ko] undefined!
>> WARNING: "kernel_recvmsg" [fs/dlm/dlm.ko] undefined!
>> WARNING: "config_item_get" [fs/dlm/dlm.ko] undefined!
>> WARNING: "config_group_init" [fs/dlm/dlm.ko] undefined!
>>   CC      arch/x86_64/boot/compressed/misc.o
>>   OBJCOPY arch/x86_64/boot/compressed/vmlinux.bin
>> make[1]: *** [__modpost] Error 1
>> make: *** [modules] Error 2
>>
> Which of the various methods (oldconfig, xconfig, menuconfig, etc) did
> you use to generate this config?

make randconfig

-- 
~Randy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/