linux-kernel - Re: [2.6 patch] arch/parisc/Makefile: remove GCC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 1 Dec 2006 11:23:55 -0700
From:	Grant Grundler <grundler@...isc-linux.org>
To:	Adrian Bunk <bunk@...sta.de>
Cc:	Andrew Morton <akpm@...l.org>, Sam Ravnborg <sam@...nborg.org>,
	Matthew Wilcox <willy@...isc-linux.org>,
	grundler@...isc-linux.org, parisc-linux@...isc-linux.org,
	linux-kernel@...r.kernel.org, Kyle McMartin <kyle@...artin.ca>
Subject: Re: [2.6 patch] arch/parisc/Makefile: remove GCC_VERSION

On Fri, Dec 01, 2006 at 12:49:08PM +0100, Adrian Bunk wrote:
> This patch removes the usage of GCC_VERSION from arch/parisc/Makefile.
> 
> There are no functional changes, it simply makes it a bit shorter (and 
> removes the last instance of GCC_VERSION in the kernel).

Thanks!
I've committed a variant of this to git://git.parisc-linux.org/git/linux-2.6.git
I didn't test the failure case - only that it doesn't trigger with
my current gcc 4.x compilers.

I expect Kyle will push parisc tree to linus in the near future.

Signed-off-by: Grant Grundler <grundler@...isc-linux.org>


diff --git a/arch/parisc/Makefile b/arch/parisc/Makefile
index 9b7e424..760567a 100644
--- a/arch/parisc/Makefile
+++ b/arch/parisc/Makefile
@@ -35,12 +35,8 @@ FINAL_LD=$(CROSS_COMPILE)ld --warn-commo
 
 OBJCOPY_FLAGS =-O binary -R .note -R .comment -S
 
-GCC_VERSION     := $(call cc-version)
-ifneq ($(shell if [ -z $(GCC_VERSION) ] ; then echo "bad"; fi ;),)
-$(error Sorry, couldn't find ($(cc-version)).)
-endif
-ifneq ($(shell if [ $(GCC_VERSION) -lt 0303 ] ; then echo "bad"; fi ;),)
-$(error Sorry, your compiler is too old ($(GCC_VERSION)).  GCC v3.3 or above is required.)
+ifneq ($(call cc-ifversion, -lt, 0303, "bad"),)
+$(error Sorry, GCC v3.3 or above is required.)
 endif
 
 cflags-y	:= -pipe
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/