linux-kernel - proposed patch: standardize white space for "#endif /* __KERNEL_

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Sat, 2 Dec 2006 08:32:54 -0500 (EST)
From:	"Robert P. J. Day" <rpjday@...dspring.com>
To:	Linux kernel mailing list <linux-kernel@...r.kernel.org>
Subject: proposed patch:  standardize white space for "#endif /* __KERNEL__
 */" directives

  i've got a one-line perl command that runs through include/linux and
standardizes all of the "#endif" directives for "__KERNEL__" into a
single variant

#endif /* __KERNEL__ */

where all of the whitespace bits above are a single space and nothing
more.

  while this is clearly just aesthetic and involves only whitespace
transformation, it was handy when i was messing around with what
happened during "make headers_install" as i was trying to match the
opening and closing __KERNEL__ directives, and i had to accommodate
that some of those #endif directives had a space, and others a tab, or
multiple spaces, or multiple tabs, etc.  grrrrrrrrrr.

  is it worth submitting this kind of whitespace-related patch?
obviously, it can be done for the entire tree (perhaps in a multi-part
patch) or just include/linux where i was using it.

  if that goes in, a follow-up patch would add any missing __KERNEL__
comments to the corresponding #endif directives so that, visually, it
would be far easier to see the nesting.

  thoughts?  or a waste of time?

rday

p.s.  there is the occasional

#endif    // __KERNEL__

directive as well, but that's obviously just as easy to handle.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/