linux-kernel - Re: [PATCH] fs: Convert kmalloc()+memset() combo to kzalloc().

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 3 Dec 2006 11:40:07 -0500 (EST)
From:	"Robert P. J. Day" <rpjday@...dspring.com>
To:	Alan <alan@...rguk.ukuu.org.uk>
cc:	Linux kernel mailing list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] fs: Convert kmalloc()+memset() combo to kzalloc().

On Sun, 3 Dec 2006, Alan wrote:

> >  	if (!p) {
> > -		p = kmalloc(sizeof(*p), GFP_KERNEL);
> > +		p = kzalloc(sizeof(*p), GFP_KERNEL);
> >  		if (!p)
> >  			return -ENOMEM;
> >  		file->private_data = p;
> >  	}
> > -	memset(p, 0, sizeof(*p));
> >  	mutex_init(&p->lock);
> >  	p->op = op;
>
>
> NAK
>
> If p was already set (ie private data existed) the old code zeroed it,
> your code does not, but only zeroes the new stuff.

whoops, sorry, my bad.

rday
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/